linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm, oom: base root bonus on current usage
Date: Wed, 29 Jan 2014 16:35:36 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1401291628340.22974@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140129122813.59d32e5c5dad3efc2248bc60@linux-foundation.org>

On Wed, 29 Jan 2014, Andrew Morton wrote:

> This changelog has deteriorated :( We should provide sufficient info so
> that people will be able to determine whether this patch will fix a
> problem they or their customers are observing.  And so that people who
> maintain -stable and its derivatives can decide whether to backport it.
> 
> I went back and stole some text from the v1 patch.  Please review the
> result.  The changelog would be even better if it were to describe the
> new behaviour under the problematic workloads.
> 

The new changelog looks fine with the exception of the mention of sshd 
which typically sets itself to be disabled from oom killing altogether.

> We don't think -stable needs this?
> 

Nobody has reported it in over three years as causing an issue, probably 
because people typically have enough memory that oom kills don't come from 
a ton of small processes allocating memory that can't be reclaimed, 
there's usually at least one large process to kill.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-01-30  0:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15 23:43 [patch] mm: oom_kill: revert 3% system memory bonus for privileged tasks Johannes Weiner
2014-01-16  0:18 ` David Rientjes
2014-01-16  7:07   ` Johannes Weiner
2014-01-22  4:53     ` David Rientjes
2014-01-24  4:05       ` Johannes Weiner
2014-01-26  3:48         ` [patch] mm, oom: base root bonus on current usage David Rientjes
2014-01-26 15:27           ` Johannes Weiner
2014-01-29 20:28           ` Andrew Morton
2014-01-30  0:35             ` David Rientjes [this message]
2014-01-30  2:12             ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1401291628340.22974@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox