From: David Rientjes <rientjes@google.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cl@linux-foundation.org, penberg@kernel.org, mpm@selenic.com,
akpm@linux-foundation.org
Subject: Re: [RFC][PATCH] mm: sl[uo]b: fix misleading comments
Date: Tue, 28 Jan 2014 21:02:36 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401282102240.20167@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140128222450.0B32C3FD@viggo.jf.intel.com>
On Tue, 28 Jan 2014, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> On x86, SLUB creates and handles <=8192-byte allocations internally.
> It passes larger ones up to the allocator. Saying "up to order 2" is,
> at best, ambiguous. Is that order-1? Or (order-2 bytes)? Make
> it more clear.
>
> SLOB commits a similar sin. It *handles* page-size requests, but the
> comment says that it passes up "all page size and larger requests".
>
> SLOB also swaps around the order of the very-similarly-named
> KMALLOC_SHIFT_HIGH and KMALLOC_SHIFT_MAX #defines. Make it
> consistent with the order of the other two allocators.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-29 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 22:24 Dave Hansen
2014-01-29 5:02 ` David Rientjes [this message]
2014-01-29 15:58 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401282102240.20167@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox