From: David Rientjes <rientjes@google.com>
To: Alex Thorlton <athorlton@sgi.com>
Cc: Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rik van Riel <riel@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Oleg Nesterov <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andy Lutomirski <luto@amacapital.net>,
Al Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: thp: Add per-mm_struct flag to control THP
Date: Wed, 22 Jan 2014 13:46:04 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401221343580.22014@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140122175328.GO18196@sgi.com>
On Wed, 22 Jan 2014, Alex Thorlton wrote:
> > I would expect that the alternative solution to a per-mm switch is to
> > reserve the naturally aligned pages for a THP promotion. Have a threshold
> > of pages pages that must be faulted before the full THP's worth of pages
> > is allocated, zero'd and a huge pmd established. That would defer the
> > THP setup costs until it was detected that it was necessary.
>
> I have some half-finished patches that I was working on a month or so
> ago, to do exactly this (I think you were involved with some of the
> discussion, maybe? I'd have to dig up the e-mails to be sure). After
> cycling through numerous other methods of handling this problem, I still
> like that idea, but I think it's going to require a decent amount of
> effort to get finished.
>
If you're going to go this route, I think a sane value would be
max_ptes_none that controls when khugepaged would re-collapse a split
hugepage into another hugepage after something does madvise(MADV_DONTNEED)
to a region, for example. Otherwise it could collapse that memory into a
hugepage even though it wasn't faulted as huge.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-22 21:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 19:55 Alex Thorlton
2014-01-10 20:23 ` Kirill A. Shutemov
2014-01-10 22:01 ` Alex Thorlton
2014-01-10 22:10 ` Peter Zijlstra
2014-01-10 22:39 ` Alex Thorlton
2014-01-14 15:44 ` Mel Gorman
2014-01-14 19:38 ` Alex Thorlton
2014-01-22 10:26 ` Mel Gorman
2014-01-22 17:53 ` Alex Thorlton
2014-01-22 21:46 ` David Rientjes [this message]
2014-01-10 22:23 ` Kirill A. Shutemov
2014-01-14 15:47 ` Mel Gorman
2014-01-11 16:11 ` Oleg Nesterov
2014-01-11 15:53 ` Oleg Nesterov
2014-01-11 19:30 ` Alex Thorlton
2014-01-12 13:56 ` Oleg Nesterov
2014-01-13 18:59 ` Alex Thorlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401221343580.22014@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox