From: David Rientjes <rientjes@google.com>
To: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, liuj97@gmail.com,
santosh.shilimkar@ti.com, grygorii.strashko@ti.com,
iamjoonsoo.kim@lge.com, robin.m.holt@gmail.com,
tangchen@cn.fujitsu.com, yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 1/3] mm/nobootmem: Fix unused variable
Date: Tue, 21 Jan 2014 01:51:52 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401210150220.29987@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140121075738.771d29b3@lilie>
On Tue, 21 Jan 2014, Philipp Hachtmann wrote:
> > Not sure why you don't just do a one line patch:
> >
> > - phys_addr_t size;
> > + phys_addr_t size __maybe_unused;
> > to fix it.
>
> Just because I did not know that __maybe_unused thing.
>
- phys_addr_t size;
+ phys_addr_t size = 0;
would have done the same thing.
The compiler generated code isn't going to change with either of these, so
we're only talking about how the source code is structured. If you and
Andrew believe that adding block scope to something so trivial then that's
your taste. Looks ugly to me.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-21 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 11:32 [PATCH V5 0/3] mm/memblock: Excluded memory Philipp Hachtmann
2014-01-20 11:32 ` [PATCH V5 1/3] mm/nobootmem: Fix unused variable Philipp Hachtmann
2014-01-20 16:28 ` Robin Holt
2014-01-21 6:16 ` David Rientjes
2014-01-21 6:57 ` Philipp Hachtmann
2014-01-21 9:51 ` David Rientjes [this message]
2014-01-20 11:32 ` [PATCH V5 2/3] mm/memblock: Add support for excluded memory areas Philipp Hachtmann
2014-01-22 11:18 ` Philipp Hachtmann
2014-01-22 20:41 ` Andrew Morton
2014-01-22 15:27 ` Robin Holt
2014-01-20 11:32 ` [PATCH V5 3/3] mm/memblock: Cleanup and refactoring after addition of nomap Philipp Hachtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401210150220.29987@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=phacht@linux.vnet.ibm.com \
--cc=robin.m.holt@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=tangchen@cn.fujitsu.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox