From: David Rientjes <rientjes@google.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Alex Shi <alex.shi@linaro.org>, Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Rik van Riel <riel@redhat.com>, H Peter Anvin <hpa@zytor.com>,
Linux-X86 <x86@kernel.org>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: vmstat: Do not display stats for TLB flushes unless debugging
Date: Thu, 16 Jan 2014 15:22:12 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401161515540.4182@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140116111205.GN4963@suse.de>
On Thu, 16 Jan 2014, Mel Gorman wrote:
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 7249614..def5dd2 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -851,12 +851,14 @@ const char * const vmstat_text[] = {
> "thp_zero_page_alloc",
> "thp_zero_page_alloc_failed",
> #endif
> +#ifdef CONFIG_DEBUG_TLBFLUSH
> #ifdef CONFIG_SMP
> "nr_tlb_remote_flush",
> "nr_tlb_remote_flush_received",
> -#endif
> +#endif /* CONFIG_SMP */
> "nr_tlb_local_flush_all",
> "nr_tlb_local_flush_one",
> +#endif /* CONFIG_DEBUG_TLBFLUSH */
>
> #endif /* CONFIG_VM_EVENTS_COUNTERS */
> };
Hmm, so why are NR_TLB_REMOTE_FLUSH{,_RECEIVED} defined for !CONFIG_SMP in
linux-next?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-16 23:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 14:34 [PATCH 0/5] Fix ebizzy performance regression due to X86 TLB range flush v3 Mel Gorman
2014-01-09 14:34 ` [PATCH 1/5] x86: mm: Account for TLB flushes only when debugging Mel Gorman
2014-01-09 19:43 ` Rik van Riel
2014-01-16 11:12 ` [PATCH] mm: vmstat: Do not display stats for TLB flushes unless debugging Mel Gorman
2014-01-16 12:25 ` Rik van Riel
2014-01-16 23:22 ` David Rientjes [this message]
2014-01-17 8:53 ` Mel Gorman
2014-01-09 14:34 ` [PATCH 2/5] x86: mm: Clean up inconsistencies when flushing TLB ranges Mel Gorman
2014-01-09 19:47 ` Rik van Riel
2014-01-09 14:34 ` [PATCH 3/5] x86: mm: Eliminate redundant page table walk during TLB range flushing Mel Gorman
2014-01-09 19:49 ` Rik van Riel
2014-01-09 14:34 ` [PATCH 4/5] x86: mm: Change tlb_flushall_shift for IvyBridge Mel Gorman
2014-01-09 19:59 ` Rik van Riel
2014-01-09 14:34 ` [PATCH 5/5] mm: x86: Revisit tlb_flushall_shift tuning for page flushes except on IvyBridge Mel Gorman
2014-01-09 20:00 ` Rik van Riel
2014-01-09 21:39 ` [PATCH 0/5] Fix ebizzy performance regression due to X86 TLB range flush v3 Davidlohr Bueso
2014-01-16 14:01 ` [TLB range flush] +34.7% hackbench.throughput Fengguang Wu
2014-01-16 18:49 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401161515540.4182@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linaro.org \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox