From: David Rientjes <rientjes@google.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru
Date: Tue, 14 Jan 2014 18:31:31 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401141829530.32645@chino.kir.corp.google.com> (raw)
In-Reply-To: <20140114180044.1E401C47@viggo.jf.intel.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1469 bytes --]
On Tue, 14 Jan 2014, Dave Hansen wrote:
> diff -puN include/linux/mm_types.h~make-slab-use-page-lru-vs-list-consistently include/linux/mm_types.h
> --- a/include/linux/mm_types.h~make-slab-use-page-lru-vs-list-consistently 2014-01-14 09:57:56.099621967 -0800
> +++ b/include/linux/mm_types.h 2014-01-14 09:57:56.106622281 -0800
> @@ -124,6 +124,8 @@ struct page {
> union {
> struct list_head lru; /* Pageout list, eg. active_list
> * protected by zone->lru_lock !
> + * Can be used as a generic list
> + * by the page owner.
> */
> struct { /* slub per cpu partial pages */
> struct page *next; /* Next partial slab */
> @@ -136,7 +138,6 @@ struct page {
> #endif
> };
>
> - struct list_head list; /* slobs list of pages */
> struct slab *slab_page; /* slab fields */
> struct rcu_head rcu_head; /* Used by SLAB
> * when destroying via RCU
Did you try with a CONFIG_BLOCK config?
block/blk-mq.c: In function a??blk_mq_free_rq_mapa??:
block/blk-mq.c:1094:10: error: a??struct pagea?? has no member named a??lista??
block/blk-mq.c:1094:10: warning: initialization from incompatible pointer type [enabled by default]
block/blk-mq.c:1094:10: error: a??struct pagea?? has no member named a??lista??
block/blk-mq.c:1095:22: error: a??struct pagea?? has no member named a??lista??
block/blk-mq.c: In function a??blk_mq_init_rq_mapa??:
block/blk-mq.c:1159:22: error: a??struct pagea?? has no member named a??lista??
next prev parent reply other threads:[~2014-01-15 2:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 18:00 [RFC][PATCH 0/9] re-shrink 'struct page' when SLUB is on Dave Hansen
2014-01-14 18:00 ` [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru Dave Hansen
2014-01-14 19:31 ` Christoph Lameter
2014-01-15 2:31 ` David Rientjes [this message]
2014-01-15 6:58 ` Dave Hansen
2014-01-15 7:16 ` David Rientjes
2014-01-16 0:11 ` Kirill A. Shutemov
2014-01-14 18:00 ` [RFC][PATCH 2/9] mm: slub: abstract out double cmpxchg option Dave Hansen
2014-01-14 19:49 ` Christoph Lameter
2014-01-14 21:41 ` Dave Hansen
2014-01-15 2:37 ` David Rientjes
2014-01-16 16:45 ` Christoph Lameter
2014-01-16 17:13 ` Dave Hansen
2014-01-14 18:00 ` [RFC][PATCH 3/9] mm: page->pfmemalloc only used by slab/skb Dave Hansen
2014-01-14 19:49 ` Christoph Lameter
2014-01-14 22:17 ` Dave Hansen
2014-01-15 2:45 ` David Rientjes
2014-01-16 0:16 ` Kirill A. Shutemov
2014-01-14 18:00 ` [RFC][PATCH 4/9] mm: slabs: reset page at free Dave Hansen
2014-01-15 2:48 ` David Rientjes
2014-01-16 18:35 ` Dave Hansen
2014-01-16 18:32 ` Christoph Lameter
2014-01-14 18:00 ` [RFC][PATCH 5/9] mm: rearrange struct page Dave Hansen
2014-01-16 0:20 ` Kirill A. Shutemov
2014-01-16 18:34 ` Christoph Lameter
2014-01-16 22:29 ` Dave Hansen
2014-01-17 14:58 ` Christoph Lameter
2014-01-14 18:01 ` [RFC][PATCH 6/9] mm: slub: rearrange 'struct page' fields Dave Hansen
2014-01-14 18:01 ` [RFC][PATCH 7/9] mm: slub: remove 'struct page' alignment restrictions Dave Hansen
2014-01-14 18:01 ` [RFC][PATCH 8/9] mm: slub: cleanups after code churn Dave Hansen
2014-01-14 18:01 ` [RFC][PATCH 9/9] mm: fix alignment checks on 32-bit Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401141829530.32645@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox