From: David Rientjes <rientjes@google.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp
Date: Thu, 2 Jan 2014 15:36:45 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401021534320.492@chino.kir.corp.google.com> (raw)
In-Reply-To: <52C5E3C2.6020205@intel.com>
On Thu, 2 Jan 2014, Dave Hansen wrote:
> > The default value of min_free_kbytes depends on the implementation of the
> > VM regardless of any config options that you may have enabled. We don't
> > specify what the non-thp default is in the kernel log, so why do we need
> > to specify what the thp default is?
>
> Let's say enabling THP made my system behave badly. How do I get it
> back to the state before I enabled THP? The user has to have gone and
> recorded what their min_free_kbytes was before turning THP on in order
> to get it back to where it was. Folks also have to either plan in
> advance (archiving *ALL* the sysctl settings), somehow *know* somehow
> that THP can affect min_free_kbytes, or just plain be clairvoyant.
>
How is this different from some initscript changing the value? We should
either specify that min_free_kbytes changed from its default, which may
change from kernel version to kernel version itself, in all cases or just
leave it as it currently is. There's no reason to special-case thp in
this way if there are other ways to change the value.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-02 23:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 0:29 Han Pingtian
2014-01-02 18:05 ` Dave Hansen
2014-01-02 21:58 ` David Rientjes
2014-01-02 22:10 ` Dave Hansen
2014-01-02 23:36 ` David Rientjes [this message]
2014-01-02 23:48 ` Dave Hansen
2014-01-03 3:33 ` Han Pingtian
2014-01-03 18:17 ` Dave Hansen
2014-01-05 0:35 ` Han Pingtian
2014-01-06 16:46 ` Michal Hocko
2014-01-08 3:59 ` Han Pingtian
2014-01-08 8:20 ` Han Pingtian
2014-01-08 10:16 ` Michal Hocko
2014-01-09 7:32 ` Han Pingtian
2014-01-09 9:02 ` Michal Hocko
2014-01-09 21:15 ` David Rientjes
2014-01-10 8:05 ` Michal Hocko
2014-01-10 8:13 ` Andrew Morton
2014-01-10 8:17 ` Michal Hocko
2014-01-11 3:27 ` Han Pingtian
2014-01-14 20:07 ` Han Pingtian
2014-01-14 23:52 ` Andrew Morton
2014-01-15 0:25 ` David Rientjes
2014-01-15 0:35 ` Andrew Morton
2014-01-15 0:52 ` David Rientjes
2014-01-15 15:22 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401021534320.492@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox