linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Michal Hocko <mhocko@suse.cz>, Mel Gorman <mgorman@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: add show num_poisoned_pages when oom
Date: Mon, 9 Dec 2013 14:05:25 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1312091405170.11026@chino.kir.corp.google.com> (raw)
In-Reply-To: <1386625778-kutyp5f6-mutt-n-horiguchi@ah.jp.nec.com>

On Mon, 9 Dec 2013, Naoya Horiguchi wrote:

> > Show num_poisoned_pages when oom, it is helpful to find the reason.
> > 
> > Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> > ---
> >  lib/show_mem.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/lib/show_mem.c b/lib/show_mem.c
> > index 5847a49..1cbdcd8 100644
> > --- a/lib/show_mem.c
> > +++ b/lib/show_mem.c
> > @@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
> >  	printk("%lu pages in pagetable cache\n",
> >  		quicklist_total_size());
> >  #endif
> > +#ifdef CONFIG_MEMORY_FAILURE
> > +	printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
> > +#endif
> >  }
> 
> I think that just "poisoned" could be confusing because this word seems to
> be used also in other context (like slab and list_debug handling.)
> "hwpoisoned" or "hardware corrupted" (which is the same label in /proc/meminfo)
> looks better to me.
> 

Ah, good point.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2013-12-09 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  9:52 Xishi Qiu
2013-12-09 15:50 ` Michal Hocko
2013-12-09 19:50 ` David Rientjes
2013-12-09 21:49 ` Naoya Horiguchi
2013-12-09 22:05   ` David Rientjes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1312091405170.11026@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=qiuxishi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox