From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f174.google.com (mail-qc0-f174.google.com [209.85.216.174]) by kanga.kvack.org (Postfix) with ESMTP id 55DA66B0037 for ; Thu, 5 Dec 2013 18:14:35 -0500 (EST) Received: by mail-qc0-f174.google.com with SMTP id n7so4118915qcx.19 for ; Thu, 05 Dec 2013 15:14:35 -0800 (PST) Received: from mail-yh0-x232.google.com (mail-yh0-x232.google.com [2607:f8b0:4002:c01::232]) by mx.google.com with ESMTPS id a8si30673716qch.30.2013.12.05.15.14.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Dec 2013 15:14:34 -0800 (PST) Received: by mail-yh0-f50.google.com with SMTP id b6so13244970yha.37 for ; Thu, 05 Dec 2013 15:14:34 -0800 (PST) Date: Thu, 5 Dec 2013 15:14:31 -0800 (PST) From: David Rientjes Subject: Re: linux-next: Tree for Dec 3 (mm/Kconfig) In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Sima Baymani Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org, tangchen@cn.fujitsu.com, akpm@linux-foundation.org, linux-mm@kvack.org, aquini@redhat.com, linux-kernel@vger.kernel.org, gang.chen@asianux.com, aneesh.kumar@linux.vnet.ibm.com, isimatu.yasuaki@jp.fujitsu.com, kirill.shutemov@linux.intel.com, sjenning@linux.vnet.ibm.com, darrick.wong@oracle.com On Thu, 5 Dec 2013, Sima Baymani wrote: > > CONFIG_HWPOISON_INJECT is unrelated, it already depends on CONFIG_PROC_FS. > > > > CONFIG_PROC_PAGE_MONITOR is obviously only useful for CONFIG_PROC_FS, so > > the correct fix would be to make CONFIG_MEM_SOFT_DIRTY depend on > > CONFIG_PROC_FS. > > > > Want to try sending a patch? > > You bet! > > However, I have the slightest confusion: > I tested what you suggested by running "make oldconfig", and it does > eliminate the error. However, I can't figure out why it's enough with > adding the dependency for PROC_FS in MEM_SOFT_DIRTY, if > PROC_PAGE_MONITOR depends on both? > "select" will force the option to be selected regardless of its dependencies, so in this case you have CONFIG_MEM_SOFT_DIRTY set and CONFIG_PROC_FS unset and CONFIG_MEM_SOFT_DIRTY enables PROC_PAGE_MONITOR which depends on CONFIG_PROC_FS. The warning you're fixing shows the missing dependency. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org