From: David Rientjes <rientjes@google.com>
To: Sima Baymani <sima.baymani@gmail.com>
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
tangchen@cn.fujitsu.com, akpm@linux-foundation.org,
linux-mm@kvack.org, aquini@redhat.com,
linux-kernel@vger.kernel.org, gang.chen@asianux.com,
aneesh.kumar@linux.vnet.ibm.com, isimatu.yasuaki@jp.fujitsu.com,
kirill.shutemov@linux.intel.com, sjenning@linux.vnet.ibm.com,
darrick.wong@oracle.com
Subject: Re: linux-next: Tree for Dec 3 (mm/Kconfig)
Date: Thu, 5 Dec 2013 15:14:31 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1312051512490.7717@chino.kir.corp.google.com> (raw)
In-Reply-To: <CAL8k4FzPYZ1Ar1w2rbR7_UWzvvCKRqXMWwJLLFNBNg=VRS3riQ@mail.gmail.com>
On Thu, 5 Dec 2013, Sima Baymani wrote:
> > CONFIG_HWPOISON_INJECT is unrelated, it already depends on CONFIG_PROC_FS.
> >
> > CONFIG_PROC_PAGE_MONITOR is obviously only useful for CONFIG_PROC_FS, so
> > the correct fix would be to make CONFIG_MEM_SOFT_DIRTY depend on
> > CONFIG_PROC_FS.
> >
> > Want to try sending a patch?
>
> You bet!
>
> However, I have the slightest confusion:
> I tested what you suggested by running "make oldconfig", and it does
> eliminate the error. However, I can't figure out why it's enough with
> adding the dependency for PROC_FS in MEM_SOFT_DIRTY, if
> PROC_PAGE_MONITOR depends on both?
>
"select" will force the option to be selected regardless of its
dependencies, so in this case you have CONFIG_MEM_SOFT_DIRTY set and
CONFIG_PROC_FS unset and CONFIG_MEM_SOFT_DIRTY enables PROC_PAGE_MONITOR
which depends on CONFIG_PROC_FS. The warning you're fixing shows the
missing dependency.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-12-05 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 20:43 Sima Baymani
2013-12-05 0:00 ` David Rientjes
2013-12-05 18:28 ` Sima Baymani
2013-12-05 23:14 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1312051512490.7717@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=aquini@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=gang.chen@asianux.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sima.baymani@gmail.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox