linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Vladimir Murzin <murzin.v@gmail.com>,
	linux-mm@kvack.org, Greg Thelen <gthelen@google.com>,
	Glauber Costa <glommer@gmail.com>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Rik van Riel <riel@redhat.com>, Joern Engel <joern@logfs.org>,
	Hugh Dickins <hughd@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: user defined OOM policies
Date: Mon, 25 Nov 2013 17:36:22 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1311251731430.27270@chino.kir.corp.google.com> (raw)
In-Reply-To: <20131121171307.GB16703@dhcp22.suse.cz>

On Thu, 21 Nov 2013, Michal Hocko wrote:

> > It's an interesting idea but unfortunately a non-starter for us because 
> > our users don't have root,
> 
> I wouldn't see this as a problem. You can still have a module which
> exports the notification interface you need. Including timeout
> fallback. That would be trivial to implement and maybe more appropriate
> to very specific environments. Moreover the global OOM handling wouldn't
> be memcg bound.
> 

The memcg userspace oom handlers are effectively system userspace oom 
handlers for everything at that memcg and its descendant memcgs, the 
interface for the system oom handler and the memcg oom handlers would be 
identical.  We could certainly make the hook into a module by defining 
some sort of API that could be exported, but I believe the proposal 
empowers userspace to handle the oom situations in all possible scenarios 
(notification, memory reserve, timeout) that it would stand alone as the 
only user in the kernel of such an API and that API itself makes the code 
unnecessarily complex.

> > we create their memcg tree and then chown it to the user.  They can
> > freely register for oom notifications but cannot load their own kernel
> > modules for their own specific policy.
> 
> yes I see but that requires just a notification interface. It doesn't
> have to be memcg specific, right?

They also need the memory reserve to do anything useful when the oom 
handler wakes up, so you'd need an API exported to modules that allows you 
to define the set of processes allowed to access such a reserve.  So the 
kernel code providing the needed functionality (notification, reserve, 
timeout) remains constant for any possible userspace oom handler.  Unless 
you're thinking of a possible implementation that can't be addressed in 
this way?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-11-26  1:36 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 13:14 Michal Hocko
2013-11-19 13:40 ` Michal Hocko
2013-11-20  8:02   ` David Rientjes
2013-11-20 15:22     ` Michal Hocko
2013-11-20 17:14       ` Luigi Semenzato
2013-11-21  3:36         ` David Rientjes
2013-11-21  7:03           ` Luigi Semenzato
2013-11-22 18:08             ` Johannes Weiner
2013-11-28 11:36               ` Michal Hocko
2013-11-26  1:29             ` David Rientjes
2013-11-28 11:42               ` Michal Hocko
2013-12-02 23:09                 ` David Rientjes
2013-11-21  3:33       ` David Rientjes
2013-11-28 11:54         ` Michal Hocko
2013-12-02 23:07           ` David Rientjes
2013-12-04  5:19             ` [patch 1/8] fork: collapse copy_flags into copy_process David Rientjes
2013-12-04  5:19               ` [patch 2/8] mm, mempolicy: rename slab_node for clarity David Rientjes
2013-12-04 15:21                 ` Christoph Lameter
2013-12-04  5:20               ` [patch 3/8] mm, mempolicy: remove per-process flag David Rientjes
2013-12-04 15:24                 ` Christoph Lameter
2013-12-05  0:53                   ` David Rientjes
2013-12-05 19:05                     ` Christoph Lameter
2013-12-05 23:53                       ` David Rientjes
2013-12-06 14:46                         ` Christoph Lameter
2013-12-04  5:20               ` [patch 4/8] mm, memcg: add tunable for oom reserves David Rientjes
2013-12-04  5:20               ` [patch 5/8] res_counter: remove interface for locked charging and uncharging David Rientjes
2013-12-04  5:20               ` [patch 6/8] res_counter: add interface for maximum nofail charge David Rientjes
2013-12-04  5:20               ` [patch 7/8] mm, memcg: allow processes handling oom notifications to access reserves David Rientjes
2013-12-04  5:45                 ` Johannes Weiner
2013-12-05  1:49                   ` David Rientjes
2013-12-05  2:50                     ` Tejun Heo
2013-12-05 23:49                       ` David Rientjes
2013-12-06 17:34                         ` Johannes Weiner
2013-12-07 16:38                           ` Tim Hockin
2013-12-07 17:40                             ` Johannes Weiner
2013-12-07 18:12                               ` Tim Hockin
2013-12-07 19:06                                 ` Johannes Weiner
2013-12-07 21:04                                   ` Tim Hockin
2013-12-06 19:01                         ` Tejun Heo
2013-12-09 20:10                           ` David Rientjes
2013-12-09 22:37                             ` Johannes Weiner
2013-12-10 21:50                             ` Tejun Heo
2013-12-10 23:55                               ` David Rientjes
2013-12-11  9:49                                 ` Mel Gorman
2013-12-11 12:42                                 ` Tejun Heo
2013-12-12  5:37                                   ` Tim Hockin
2013-12-12 14:21                                     ` Tejun Heo
2013-12-12 16:32                                       ` Michal Hocko
2013-12-12 16:37                                         ` Tejun Heo
2013-12-12 18:42                                       ` Tim Hockin
2013-12-12 19:23                                         ` Tejun Heo
2013-12-13  0:23                                           ` Tim Hockin
2013-12-13 11:47                                             ` Tejun Heo
2013-12-04  5:20               ` [patch 8/8] mm, memcg: add memcg oom reserve documentation David Rientjes
2013-11-20 17:25     ` user defined OOM policies Vladimir Murzin
2013-11-20 17:21   ` Vladimir Murzin
2013-11-20 17:33     ` Michal Hocko
2013-11-21  3:38       ` David Rientjes
2013-11-21 17:13         ` Michal Hocko
2013-11-26  1:36           ` David Rientjes [this message]
2013-11-22  7:28       ` Vladimir Murzin
2013-11-22 13:18         ` Michal Hocko
2013-11-20  7:50 ` David Rientjes
2013-11-22  0:19 ` Jörn Engel
2013-11-26  1:31   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1311251731430.27270@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=glommer@gmail.com \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=joern@logfs.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=murzin.v@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox