From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Kees Cook <keescook@chromium.org>, Rik van Riel <riel@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [patch -mm] mm, mempolicy: silence gcc warning
Date: Mon, 25 Nov 2013 15:30:47 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1311251529260.5495@chino.kir.corp.google.com> (raw)
In-Reply-To: <20131125123108.79c80eb59c2b1bc41c879d9e@linux-foundation.org>
On Mon, 25 Nov 2013, Andrew Morton wrote:
> > > It worries me that the CONFIG_NUMA=n version of mpol_to_str() doesn't
> > > stick a '\0' into *buffer. Hopefully it never gets called...
> >
> > Don't worry. It never happens. Currently, all of caller depend on CONFIG_NUMA.
> > However it would be nice if CONFIG_NUMA=n version of mpol_to_str() is
> > implemented
> > more carefully. I don't know who's mistake.
>
> Put a BUG() in there?
>
Why make it a fatal runtime error when it can simply be a compile time
error since calling mpol_to_str() without CONFIG_NUMA is unnecessary?
There wouldn't be a mempolicy to convert, the struct has no fields in such
a configuration.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-25 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 2:12 David Rientjes
2013-11-13 19:20 ` Kees Cook
2013-11-20 22:15 ` Andrew Morton
2013-11-20 22:19 ` Kees Cook
2013-11-23 20:49 ` KOSAKI Motohiro
2013-11-25 20:31 ` Andrew Morton
2013-11-25 23:30 ` David Rientjes [this message]
2013-11-25 23:33 ` [patch] mm, mempolicy: remove unneeded functions for UMA configs David Rientjes
2013-11-26 0:08 ` [patch -mm] mm, mempolicy: silence gcc warning KOSAKI Motohiro
2013-11-26 0:20 ` Andrew Morton
2013-11-26 18:40 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1311251529260.5495@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=keescook@chromium.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox