From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by kanga.kvack.org (Postfix) with ESMTP id BB2F86B0035 for ; Thu, 17 Oct 2013 00:19:32 -0400 (EDT) Received: by mail-pa0-f45.google.com with SMTP id rd3so2120042pab.18 for ; Wed, 16 Oct 2013 21:19:32 -0700 (PDT) Received: by mail-pa0-f50.google.com with SMTP id fa1so2070484pad.23 for ; Wed, 16 Oct 2013 21:19:30 -0700 (PDT) Date: Wed, 16 Oct 2013 21:19:28 -0700 (PDT) From: David Rientjes Subject: Re: [bug] get_maintainer.pl incomplete output In-Reply-To: <1381982635.22110.84.camel@joe-AO722> Message-ID: References: <1381982635.22110.84.camel@joe-AO722> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Joe Perches Cc: Andrew Morton , Anton Vorontsov , Michal Hocko , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, 16 Oct 2013, Joe Perches wrote: > > I haven't looked closely at scripts/get_maintainer.pl, but I recently > > wrote a patch touching mm/vmpressure.c and it doesn't list the file's > > author, Anton Vorontsov . > > > > Even when I do scripts/get_maintainer.pl -f mm/vmpressure.c, his entry is > > missing and git blame attributs >90% of the lines to his authorship. > > > > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c > > Tejun Heo (commit_signer:6/7=86%) > > Michal Hocko (commit_signer:5/7=71%) > > Andrew Morton (commit_signer:4/7=57%) > > Li Zefan (commit_signer:3/7=43%) > > "Kirill A. Shutemov" (commit_signer:1/7=14%) > > linux-mm@kvack.org (open list:MEMORY MANAGEMENT) > > linux-kernel@vger.kernel.org (open list) > > > > Any ideas? > > get_maintainer has a lot of options. > > get_maintainer tries to find people that are either > listed in the MAINTAINERS file or that have recently > (in the last year by default) worked on the file. > > If you want to find all authors, use the --git-blame option > > It's not the default because it can take quite awhile to run. > Hmm, it's a little strange to only consider recent activity when >90% of the lines were written by someone not listed. Isn't there any faster way to determine that besides using the expensive git blame? Something like weighing the output of "git show --shortstat" for all commits in "git log mm/vmpressure.c" to determine the most important recent changes? That should be fairly cheap. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org