From: David Rientjes <rientjes@google.com>
To: Alex Thorlton <athorlton@sgi.com>
Cc: linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
Rob Landley <rob@landley.net>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] Make transparent hugepages cpuset aware
Date: Tue, 11 Jun 2013 15:20:09 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1306111517200.6141@chino.kir.corp.google.com> (raw)
In-Reply-To: <1370967244-5610-1-git-send-email-athorlton@sgi.com>
On Tue, 11 Jun 2013, Alex Thorlton wrote:
> This patch adds the ability to control THPs on a per cpuset basis. Please see
> the additions to Documentation/cgroups/cpusets.txt for more information.
>
What's missing from both this changelog and the documentation you point to
is why this change is needed.
I can understand how you would want a subset of processes to not use thp
when it is enabled. This is typically where MADV_NOHUGEPAGE is used with
some type of malloc hook.
I don't think we need to do this on a cpuset level, so unfortunately I
think this needs to be reworked. Would it make sense to add a per-process
tunable to always get MADV_NOHUGEPAGE behavior for all of its sbrk() and
mmap() calls? Perhaps, but then you would need to justify why it can't be
done with a malloc hook in userspace.
This seems to just be working around a userspace issue or for a matter of
convenience, right?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-11 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 16:14 Alex Thorlton
2013-06-11 22:20 ` David Rientjes [this message]
2013-06-18 16:45 ` Alex Thorlton
2013-06-19 0:01 ` David Rientjes
2013-06-19 9:32 ` Robin Holt
2013-06-19 21:24 ` David Rientjes
2013-06-20 2:27 ` Robin Holt
2013-06-20 2:43 ` David Rientjes
2013-06-20 3:10 ` Mike Galbraith
2013-06-20 20:37 ` David Rientjes
2013-07-29 19:42 ` Alex Thorlton
2013-06-20 3:34 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1306111517200.6141@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=athorlton@sgi.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=rob@landley.net \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox