From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id A39C86B0034 for ; Tue, 11 Jun 2013 18:10:15 -0400 (EDT) Received: by mail-pd0-f172.google.com with SMTP id z10so5565678pdj.31 for ; Tue, 11 Jun 2013 15:10:14 -0700 (PDT) Date: Tue, 11 Jun 2013 15:10:12 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] slab: prevent warnings when allocating with __GFP_NOWARN In-Reply-To: <0000013f33cdc631-eadb07d1-ef08-4e2c-a218-1997eb86cde9-000000@email.amazonses.com> Message-ID: References: <1370891880-2644-1-git-send-email-sasha.levin@oracle.com> <51B62F6B.8040308@oracle.com> <0000013f3075f90d-735942a8-b4b8-413f-a09e-57d1de0c4974-000000@email.amazonses.com> <51B67553.6020205@oracle.com> <51B72323.8040207@oracle.com> <0000013f33cdc631-eadb07d1-ef08-4e2c-a218-1997eb86cde9-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Sasha Levin , Pekka Enberg , "linux-mm@kvack.org" , Andrew Morton , LKML On Tue, 11 Jun 2013, Christoph Lameter wrote: > > I think that leaving the warning makes sense to catch similar > > things which are actually bugs - we had a similar issue with > > /dev/kmsg (if I remember correctly) which actually pointed to > > a bug. > > Right. Requesting an allocation larger than even supported by the page > allocator from the slab allocators that are specializing in allocations of > small objects is usually an indication of a problem in the code. > I think we can remove the kmalloc_slab() warning that Sasha is pointing to and just fallback to the page allocator for sizes that are too large? Then the page allocator can return NULL and warn, if necessary, for orders larger than MAX_ORDER. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org