From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id 3D4EE6B0039 for ; Wed, 5 Jun 2013 23:57:48 -0400 (EDT) Received: by mail-pa0-f44.google.com with SMTP id wp1so1445747pac.3 for ; Wed, 05 Jun 2013 20:57:47 -0700 (PDT) Date: Wed, 5 Jun 2013 20:57:44 -0700 (PDT) From: David Rientjes Subject: Re: [patch 1/2] arch: invoke oom-killer from page fault In-Reply-To: <1370488193-4747-1-git-send-email-hannes@cmpxchg.org> Message-ID: References: <1370488193-4747-1-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 5 Jun 2013, Johannes Weiner wrote: > Since '1c0fe6e mm: invoke oom-killer from page fault', page fault > handlers should not directly kill faulting tasks in an out of memory > condition. I have no objection to the patch, but there's no explanation given here why exiting with a kill shouldn't be done. Is it because of memory reserves and there is no guarantee that current will be able to exit? Or is it just for consistency with other archs? > Instead, they should be invoking the OOM killer to pick > the right task. Convert the remaining architectures. > If this is a matter of memory reserves, I guess you could point people who want the current behavior (avoiding the expensiveness of the tasklist scan in the oom killer for example) to /proc/sys/vm/oom_kill_allocating_task? This changelog is a bit cryptic in its motivation. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org