From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cody P Schafer <cody@linux.vnet.ibm.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] memory_hotplug: use pgdat_resize_lock() in online_pages()
Date: Thu, 16 May 2013 14:05:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1305161404470.1348@chino.kir.corp.google.com> (raw)
In-Reply-To: <20130515162054.1c76200ee9514ca8a2054628@linux-foundation.org>
On Wed, 15 May 2013, Andrew Morton wrote:
> On Mon, 13 May 2013 16:13:06 -0700 Cody P Schafer <cody@linux.vnet.ibm.com> wrote:
>
> > mmzone.h documents node_size_lock (which pgdat_resize_lock() locks) as
> > follows:
> >
> > * Must be held any time you expect node_start_pfn, node_present_pages
> > * or node_spanned_pages stay constant. [...]
>
> Yeah, I suppose so. Although no present code sites actually do that.
>
Agreed, I see no purpose in patches 2-4 in this series as mentioned in v2.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-16 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 23:13 [PATCH v3 0/4] misc patches related to resizing nodes & zones Cody P Schafer
2013-05-13 23:13 ` [PATCH v3 1/4] mm: fix comment referring to non-existent size_seqlock, change to span_seqlock Cody P Schafer
2013-05-13 23:13 ` [PATCH v3 2/4] mmzone: note that node_size_lock should be manipulated via pgdat_resize_lock() Cody P Schafer
2013-05-13 23:13 ` [PATCH v3 3/4] memory_hotplug: use pgdat_resize_lock() in online_pages() Cody P Schafer
2013-05-15 23:20 ` Andrew Morton
2013-05-16 21:05 ` David Rientjes [this message]
2013-05-13 23:13 ` [PATCH v3 4/4] memory_hotplug: use pgdat_resize_lock() in __offline_pages() Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1305161404470.1348@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cody@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox