From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id 23F726B0200 for ; Wed, 1 May 2013 18:42:46 -0400 (EDT) Received: by mail-pa0-f53.google.com with SMTP id kq12so2681pab.26 for ; Wed, 01 May 2013 15:42:45 -0700 (PDT) Date: Wed, 1 May 2013 15:42:43 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 3/4] mmzone: note that node_size_lock should be manipulated via pgdat_resize_lock() In-Reply-To: <51819900.1010301@linux.vnet.ibm.com> Message-ID: References: <1367446635-12856-1-git-send-email-cody@linux.vnet.ibm.com> <1367446635-12856-4-git-send-email-cody@linux.vnet.ibm.com> <51819900.1010301@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Cody P Schafer Cc: Andrew Morton , Linux MM , LKML On Wed, 1 May 2013, Cody P Schafer wrote: > > > Signed-off-by: Cody P Schafer > > > > Nack, pgdat_resize_unlock() is unnecessary if irqs are known to be > > disabled. > > > > All this patch does is is indicate that rather than using node_size_lock > directly (as it won't be around without CONFIG_MEMORY_HOTPLUG), one should use > the pgdat_resize_[un]lock() helper macros. > I think that's obvious given the lock is surrounded by #ifdef CONFIG_MEMORY_HOTPLUG. The fact remains that hotplug code need not use pgdat_resize_lock() if irqs are disabled. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org