From: David Rientjes <rientjes@google.com>
To: Shawn Bohrer <sbohrer@rgmadvisors.com>
Cc: xfs@oss.sgi.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: deadlock on vmap_area_lock
Date: Wed, 1 May 2013 10:01:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1305010959070.16591@chino.kir.corp.google.com> (raw)
In-Reply-To: <20130501164406.GC2404@BohrerMBP.rgmadvisors.com>
On Wed, 1 May 2013, Shawn Bohrer wrote:
> Correct it doesn't and I can't prove the find command is not making
> progress, however these finds normally complete in under 15 min and
> we've let the stuck ones run for days. Additionally if this was just
> contention I'd expect to see multiple threads/CPUs contending and I
> only have a single CPU pegged running find at 99%. I should clarify
> that the perf snippet above was for the entire system. Profiling just
> the find command shows:
>
> 82.56% find [kernel.kallsyms] [k] _raw_spin_lock
Couple of options to figure out what spinlock this is: use lockstat (see
Documentation/lockstat.txt), which will also require a kernel rebuild,
some human intervention to collect the stats, and the accompanying
performance degradation, or you could try collecting
/proc/$(pidof find)/stack at regular intervals and figure out which
spinlock it is.
> > Depending on your
> > definition of "occassionally", would it be possible to run with
> > CONFIG_PROVE_LOCKING and CONFIG_LOCKDEP to see if it uncovers any real
> > deadlock potential?
>
> Yeah, I can probably enable these on a few machines and hope I get
> lucky. These machines are used for real work so I'll have to gauge
> what how significant the performance impact is to determine how many
> machines I can sacrifice to the cause.
>
You'll probably only need to enable it on one machine, if a deadlock
possibility exists here then lockdep will find it even without hitting it,
it simply has to exercise the path that leads to it. It does have a
performance degradation for that one machine, though.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-01 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 14:43 Shawn Bohrer
2013-05-01 15:57 ` David Rientjes
2013-05-01 16:44 ` Shawn Bohrer
2013-05-01 17:01 ` David Rientjes [this message]
2013-05-01 22:03 ` Dave Chinner
2013-05-02 16:21 ` Shawn Bohrer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1305010959070.16591@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sbohrer@rgmadvisors.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox