From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx132.postini.com [74.125.245.132]) by kanga.kvack.org (Postfix) with SMTP id 505116B0005 for ; Wed, 10 Apr 2013 01:52:15 -0400 (EDT) Received: by mail-da0-f42.google.com with SMTP id n15so60391dad.1 for ; Tue, 09 Apr 2013 22:52:14 -0700 (PDT) Date: Tue, 9 Apr 2013 22:52:11 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH v2 0/3] Support memory hot-delete to boot memory In-Reply-To: <1365454703.32127.8.camel@misato.fc.hp.com> Message-ID: References: <1365440996-30981-1-git-send-email-toshi.kani@hp.com> <20130408134438.2a4388a07163e10a37158eed@linux-foundation.org> <1365454703.32127.8.camel@misato.fc.hp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxram@us.ibm.com, guz.fnst@cn.fujitsu.com, tmac@hp.com, isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com, tangchen@cn.fujitsu.com, jiang.liu@huawei.com On Mon, 8 Apr 2013, Toshi Kani wrote: > > So we don't need this new code if CONFIG_MEMORY_HOTPLUG=n? If so, can > > we please arrange for it to not be present if the user doesn't need it? > > Good point! Yes, since the new function is intended for memory > hot-delete and is only called from __remove_pages() in > mm/memory_hotplug.c, it should be added as #ifdef CONFIG_MEMORY_HOTPLUG > in PATCH 2/3. > > I will make the change, and send an updated patch to PATCH 2/3. > It should actually depend on CONFIG_MEMORY_HOTREMOVE, but the pseries OF_RECONFIG_DETACH_NODE code seems to be the only code that doesn't make that distinction. CONFIG_MEMORY_HOTREMOVE acts as a wrapper to protect configs that don't have ARCH_ENABLE_MEMORY_HOTREMOVE, so we'll want to keep it around and presumably that powerpc code depends on it as well. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org