From: David Rientjes <rientjes@google.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxram@us.ibm.com, guz.fnst@cn.fujitsu.com, tmac@hp.com,
isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
tangchen@cn.fujitsu.com, jiang.liu@huawei.com
Subject: Re: [PATCH v2 0/3] Support memory hot-delete to boot memory
Date: Tue, 9 Apr 2013 22:52:11 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1304092155220.25293@chino.kir.corp.google.com> (raw)
In-Reply-To: <1365454703.32127.8.camel@misato.fc.hp.com>
On Mon, 8 Apr 2013, Toshi Kani wrote:
> > So we don't need this new code if CONFIG_MEMORY_HOTPLUG=n? If so, can
> > we please arrange for it to not be present if the user doesn't need it?
>
> Good point! Yes, since the new function is intended for memory
> hot-delete and is only called from __remove_pages() in
> mm/memory_hotplug.c, it should be added as #ifdef CONFIG_MEMORY_HOTPLUG
> in PATCH 2/3.
>
> I will make the change, and send an updated patch to PATCH 2/3.
>
It should actually depend on CONFIG_MEMORY_HOTREMOVE, but the pseries
OF_RECONFIG_DETACH_NODE code seems to be the only code that doesn't
make that distinction. CONFIG_MEMORY_HOTREMOVE acts as a wrapper to
protect configs that don't have ARCH_ENABLE_MEMORY_HOTREMOVE, so we'll
want to keep it around and presumably that powerpc code depends on it as
well.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-10 5:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 17:09 Toshi Kani
2013-04-08 17:09 ` [PATCH v2 1/3] resource: Add __adjust_resource() for internal use Toshi Kani
2013-04-10 6:10 ` David Rientjes
2013-04-10 15:39 ` Toshi Kani
2013-04-08 17:09 ` [PATCH v2 2/3] resource: Add release_mem_region_adjustable() Toshi Kani
2013-04-10 6:16 ` David Rientjes
2013-04-10 16:36 ` Toshi Kani
2013-04-08 17:09 ` [PATCH v2 3/3] mm: Change __remove_pages() to call release_mem_region_adjustable() Toshi Kani
2013-04-08 20:44 ` [PATCH v2 0/3] Support memory hot-delete to boot memory Andrew Morton
2013-04-08 20:58 ` Toshi Kani
2013-04-10 5:52 ` David Rientjes [this message]
2013-04-10 6:07 ` [patch] mm, hotplug: avoid compiling memory hotremove functions when disabled David Rientjes
2013-04-10 17:29 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1304092155220.25293@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tmac@hp.com \
--cc=toshi.kani@hp.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox