From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, hugetlb: include hugepages in meminfo
Date: Wed, 20 Mar 2013 11:46:12 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1303201145260.17761@chino.kir.corp.google.com> (raw)
In-Reply-To: <20130320095306.GA21856@dhcp22.suse.cz>
On Wed, 20 Mar 2013, Michal Hocko wrote:
> On Tue 19-03-13 17:18:12, David Rientjes wrote:
> > Particularly in oom conditions, it's troublesome that hugetlb memory is
> > not displayed. All other meminfo that is emitted will not add up to what
> > is expected, and there is no artifact left in the kernel log to show that
> > a potentially significant amount of memory is actually allocated as
> > hugepages which are not available to be reclaimed.
>
> Yes, I like the idea. It's bitten me already in the past.
>
> The only objection I have is that you print only default_hstate. You
> just need to wrap your for_each_node_state by for_each_hstate to do
> that. With that applied, feel free to add my
> Acked-by: Michal Hocko <mhocko@suse.cz>
>
I didn't do this because it isn't already exported in /proc/meminfo and
since we've made an effort to reduce the amount of information emitted by
the oom killer at oom kill time to avoid spamming the kernel log, I only
print the default hstate.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-20 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 0:18 David Rientjes
2013-03-20 9:53 ` Michal Hocko
2013-03-20 18:46 ` David Rientjes [this message]
2013-03-20 18:56 ` Michal Hocko
2013-03-20 18:58 ` David Rientjes
2013-03-20 19:21 ` Michal Hocko
2013-03-20 19:07 ` [patch v2] " David Rientjes
2013-03-20 19:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1303201145260.17761@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox