From: Sage Weil <sage@inktank.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH v2 07/18] ceph: use ->invalidatepage() length argument
Date: Tue, 5 Feb 2013 08:39:50 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1302050839260.23011@cobra.newdream.net> (raw)
In-Reply-To: <1360055531-26309-8-git-send-email-lczerner@redhat.com>
On Tue, 5 Feb 2013, Lukas Czerner wrote:
> ->invalidatepage() aop now accepts range to invalidate so we can make
> use of it in ceph_invalidatepage().
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Cc: ceph-devel@vger.kernel.org
Reviewed-by: Sage Weil <sage@inktank.com>
> ---
> fs/ceph/addr.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 8953532..1e09410 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -164,20 +164,20 @@ static void ceph_invalidatepage(struct page *page, unsigned int offset,
> if (!PageDirty(page))
> pr_err("%p invalidatepage %p page not dirty\n", inode, page);
>
> - if (offset == 0)
> + if (offset == 0 && length == PAGE_CACHE_SIZE)
> ClearPageChecked(page);
>
> ci = ceph_inode(inode);
> - if (offset == 0) {
> - dout("%p invalidatepage %p idx %lu full dirty page %u\n",
> - inode, page, page->index, offset);
> + if (offset == 0 && length == PAGE_CACHE_SIZE) {
> + dout("%p invalidatepage %p idx %lu full dirty page\n",
> + inode, page, page->index);
> ceph_put_wrbuffer_cap_refs(ci, 1, snapc);
> ceph_put_snap_context(snapc);
> page->private = 0;
> ClearPagePrivate(page);
> } else {
> - dout("%p invalidatepage %p idx %lu partial dirty page\n",
> - inode, page, page->index);
> + dout("%p invalidatepage %p idx %lu partial dirty page %u(%u)\n",
> + inode, page, page->index, offset, length);
> }
> }
>
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-05 16:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 9:11 [PATCH v2 00/18] change invalidatepage prototype to accept length Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 01/18] mm: " Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 02/18] jbd2: change jbd2_journal_invalidatepage " Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 03/18] ext4: use ->invalidatepage() length argument Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 04/18] jbd: change journal_invalidatepage() to accept length Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 05/18] xfs: use ->invalidatepage() length argument Lukas Czerner
2013-02-05 9:11 ` [PATCH v2 06/18] ocfs2: " Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 07/18] ceph: " Lukas Czerner
2013-02-05 16:39 ` Sage Weil [this message]
2013-02-05 9:12 ` [PATCH v2 08/18] gfs2: " Lukas Czerner
2013-02-05 9:47 ` [Cluster-devel] " Steven Whitehouse
2013-02-05 9:12 ` [PATCH v2 09/18] reiserfs: " Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges Lukas Czerner
2013-02-07 23:40 ` Andrew Morton
2013-02-08 9:08 ` Lukáš Czerner
2013-02-21 8:33 ` Lukáš Czerner
2013-02-21 21:49 ` Andrew Morton
2013-02-22 8:06 ` Lukáš Czerner
2013-02-05 9:12 ` [PATCH v2 11/18] Revert "ext4: remove no longer used functions in inode.c" Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 12/18] Revert "ext4: fix fsx truncate failure" Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 13/18] ext4: use ext4_zero_partial_blocks in punch_hole Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 14/18] ext4: remove unused discard_partial_page_buffers Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 15/18] ext4: remove unused code from ext4_remove_blocks() Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 16/18] ext4: update ext4_ext_remove_space trace point Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 17/18] ext4: make punch hole code path work with bigalloc Lukas Czerner
2013-02-05 9:12 ` [PATCH v2 18/18] ext4: Allow punch hole with bigalloc enabled Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1302050839260.23011@cobra.newdream.net \
--to=sage@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox