From: David Rientjes <rientjes@google.com>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: akpm@linux-foundation.org, jiang.liu@huawei.com,
wujianguo@huawei.com, hpa@zytor.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, linfeng@cn.fujitsu.com, yinghai@kernel.org,
isimatu.yasuaki@jp.fujitsu.com, rob@landley.net,
kosaki.motohiro@jp.fujitsu.com, minchan.kim@gmail.com,
mgorman@suse.de, guz.fnst@cn.fujitsu.com, rusty@rustcorp.com.au,
lliubbo@gmail.com, jaegeuk.hanse@gmail.com, tony.luck@intel.com,
glommer@parallels.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH Bug fix] acpi, movablemem_map: node0 should always be unhotpluggable when using SRAT.
Date: Wed, 30 Jan 2013 14:48:13 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1301301445270.27852@chino.kir.corp.google.com> (raw)
In-Reply-To: <5108F6A1.6060400@cn.fujitsu.com>
On Wed, 30 Jan 2013, Tang Chen wrote:
> > Exactly, there is a node 0 but it includes no online memory (and that
> > should be the case as if it was solely hotpluggable memory) at the time of
> > boot. The sysfs interfaces only get added if the memory is onlined later.
>
> OK, you mean you have only node1 at first and no node0 interface, right?
> If so, then this patch is wrong. :)
>
Not usually unless I modify my SRAT or I start pulling DIMMs, but yes,
I've booted the kernel many times in the past with no node 0 online. As
far as I know, there's no special casing that is needed for node 0 to
assume it's online and I've tried to fix up places where that assumption
has been made. I'm sure that node_online_map must include at least one
online node, obviously, but there should be no requirement that it be node
0.
> But you mean physical address 0x0 is on your node1, right? Otherwise, how
> could
> the kernel be loaded ?
>
Yes, the online pxms all point to nodes that do not have the node id of 0.
Is it possible to try earlyprintk and get a serial console connected or
reproduce it locally to find out where the problem is?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-30 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 7:54 Tang Chen
2013-01-30 8:50 ` David Rientjes
2013-01-30 9:05 ` Tang Chen
2013-01-30 9:45 ` David Rientjes
2013-01-30 10:32 ` Tang Chen
2013-01-30 22:48 ` David Rientjes [this message]
2013-01-30 15:55 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1301301445270.27852@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jaegeuk.hanse@gmail.com \
--cc=jiang.liu@huawei.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=rob@landley.net \
--cc=rusty@rustcorp.com.au \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
--cc=wency@cn.fujitsu.com \
--cc=wujianguo@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox