Re: [PATCH] mm: clean up hugepage sysfs error messages

[David Rientjes <rientjes@google.com>]

On Tue, 18 Dec 2012, Jeremy Eder wrote:

> This patch corrects a few typos in the hugepage sysfs init code.

Please sign off your patch.

> ---
>  mm/huge_memory.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 32754ee..0696fa4 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -574,19 +574,19 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj)
>  
>  	*hugepage_kobj = kobject_create_and_add("transparent_hugepage", mm_kobj);
>  	if (unlikely(!*hugepage_kobj)) {
> -		printk(KERN_ERR "hugepage: failed kobject create\n");
> +		printk(KERN_ERR "hugepage: failed to create kobject\n");

How do we know this is for thp and not hugetlbfs when it only appears in 
the kernel log?

>  		return -ENOMEM;
>  	}
>  
>  	err = sysfs_create_group(*hugepage_kobj, &hugepage_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "hugepage: failed to register hugepage group\n");
>  		goto delete_obj;
>  	}
>  
>  	err = sysfs_create_group(*hugepage_kobj, &khugepaged_attr_group);
>  	if (err) {
> -		printk(KERN_ERR "hugepage: failed register hugeage group\n");
> +		printk(KERN_ERR "hugepage: failed to register hugepage group\n");
>  		goto remove_hp_group;
>  	}
>  

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>