From: David Rientjes <rientjes@google.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH, RESEND] asm-generic, mm: pgtable: consolidate zero page helpers
Date: Wed, 12 Dec 2012 14:54:55 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1212121452430.23465@chino.kir.corp.google.com> (raw)
In-Reply-To: <20121212105538.GA14208@otc-wbsnb-06>
On Wed, 12 Dec 2012, Kirill A. Shutemov wrote:
> > What's the benefit from doing this other than generalizing some per-arch
> > code? It simply adds on more layer of redirection to try to find the
> > implementation that matters for the architecture you're hacking on.
>
> The idea of asm-generic is consolidation arch code which can be re-used
> for different arches. It also makes support of new arches easier.
>
Yeah, but you're moving is_zero_pfn() unnecessarily into a header file
when it is only used mm/memory.c and it adds a __HAVE_* definition that we
always try to reduce (both __HAVE and __ARCH definitions are frowned
upon). I don't think it's much of a win to obfuscate the code because
mips and s390 implement colored zero pages.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-12-12 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 11:53 Kirill A. Shutemov
2012-12-12 3:07 ` David Rientjes
2012-12-12 10:55 ` Kirill A. Shutemov
2012-12-12 22:54 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1212121452430.23465@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=blogic@openwrt.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox