linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>
Subject: Re: [patch] mm: introduce a common interface for balloon pages mobility fix
Date: Fri, 16 Nov 2012 14:03:45 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1211161402550.17853@chino.kir.corp.google.com> (raw)
In-Reply-To: <20121116201035.GA18145@t510.redhat.com>

On Fri, 16 Nov 2012, Rafael Aquini wrote:

> > > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
> > > head:   12dfb061e5fd15be23451418da01281625c0eeae
> > > commit: 86929cfa5f751de3d8be5a846535282730865d8a [365/437] mm: introduce a common interface for balloon pages mobility
> > > config: make ARCH=sh allyesconfig
> > > 
> > > All warnings:
> > > 
> > > warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU)
> > > warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU)
> > > --
> > > warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU)
> > > 
> > 
> > mm: introduce a common interface for balloon pages mobility fix
> > 
> > CONFIG_BALLOON_COMPACTION shouldn't be selecting options that may not be 
> > supported, so make it depend on memory compaction rather than selecting 
> > it.  CONFIG_COMPACTION is enabled by default for all configs that support 
> > it.
> >     
> 
> This is already addressed at v12 revision which is on mmtom queue already.
> 

Ah, it was merged yesterday but it depends on TRANSPARENT_HUGEPAGE rather 
than COMPACTION.  Why?  Surely thp is not the only thing that benefits 
from keeping memory defragmented for high-order allocs.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-11-16 22:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 15:13 [memcg:since-3.6 365/437] warning: (BALLOON_COMPACTION && TRANSPARENT_HUGEPAGE) selects COMPACTION which has unmet direct dependencies (MMU) kbuild test robot
2012-11-16 19:50 ` [patch] mm: introduce a common interface for balloon pages mobility fix David Rientjes
2012-11-16 20:10   ` Rafael Aquini
2012-11-16 22:03     ` David Rientjes [this message]
2012-11-27 23:50       ` David Rientjes
2012-11-28  0:03         ` Rafael Aquini
2012-11-28  0:15           ` David Rientjes
2012-11-28  9:59             ` Michal Hocko
2012-11-28 10:57             ` Rafael Aquini
2012-11-16 20:12   ` Rafael Aquini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1211161402550.17853@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox