From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id 174C66B00AA for ; Wed, 14 Nov 2012 18:12:57 -0500 (EST) Received: by mail-da0-f41.google.com with SMTP id i14so429796dad.14 for ; Wed, 14 Nov 2012 15:12:56 -0800 (PST) Date: Wed, 14 Nov 2012 15:12:54 -0800 (PST) From: David Rientjes Subject: Re: [PATCH v5 05/11] thp: change_huge_pmd(): keep huge zero page write-protected In-Reply-To: <1352300463-12627-6-git-send-email-kirill.shutemov@linux.intel.com> Message-ID: References: <1352300463-12627-1-git-send-email-kirill.shutemov@linux.intel.com> <1352300463-12627-6-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrew Morton , Andrea Arcangeli , linux-mm@kvack.org, Andi Kleen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, "Kirill A. Shutemov" On Wed, 7 Nov 2012, Kirill A. Shutemov wrote: > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d767a7c..05490b3 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1259,6 +1259,8 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, > pmd_t entry; > entry = pmdp_get_and_clear(mm, addr, pmd); > entry = pmd_modify(entry, newprot); > + if (is_huge_zero_pmd(entry)) > + entry = pmd_wrprotect(entry); > set_pmd_at(mm, addr, pmd, entry); > spin_unlock(&vma->vm_mm->page_table_lock); > ret = 1; Nack, this should be handled in pmd_modify(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org