From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id 6F8C46B0070 for ; Mon, 12 Nov 2012 16:53:39 -0500 (EST) Received: by mail-pa0-f41.google.com with SMTP id fa10so5029196pad.14 for ; Mon, 12 Nov 2012 13:53:38 -0800 (PST) Date: Mon, 12 Nov 2012 13:53:36 -0800 (PST) From: David Rientjes Subject: RE: [PATCH 1/1] mm: Export a function to read vm_committed_as In-Reply-To: <426367E2313C2449837CD2DE46E7EAF930E35B45@SN2PRD0310MB382.namprd03.prod.outlook.com> Message-ID: References: <1352600728-17766-1-git-send-email-kys@microsoft.com> <426367E2313C2449837CD2DE46E7EAF930E35B45@SN2PRD0310MB382.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: KY Srinivasan Cc: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "andi@firstfloor.org" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "kamezawa.hiroyuki@gmail.com" , "mhocko@suse.cz" , "hannes@cmpxchg.org" , "yinghan@google.com" On Sun, 11 Nov 2012, KY Srinivasan wrote: > Thanks for the prompt response. For the Linux balloon driver for Hyper-V, I need access > to the metric that reflects the system wide memory commitment made by the guest kernel. > In the Hyper-V case, this information is one of the many metrics used to drive the policy engine > on the host. Granted, the interface name I have chosen here could be more generic; how about > read_mem_commit_info(void). I am open to suggestions here. > I would suggest vm_memory_committed() and there shouldn't be a comment describing that this is just a wrapper for modules to read vm_committed_as, that's apparent from the implementation: it should be describing exactly what this value represents and why it is a useful metric (at least in the case that you're concerned about). > With regards to making changes to the Xen self ballooning code, I would like to separate that patch > from the patch that implements the exported mechanism to access the memory commitment information. Why? Is xen using it for a different inference? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org