From: David Rientjes <rientjes@google.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Linux-MM <linux-mm@kvack.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] mm: compaction: Move migration fail/success stats to migrate.c
Date: Wed, 24 Oct 2012 19:57:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1210241953280.2294@chino.kir.corp.google.com> (raw)
In-Reply-To: <1350892791-2682-2-git-send-email-mgorman@suse.de>
On Mon, 22 Oct 2012, Mel Gorman wrote:
> The compact_pages_moved and compact_pagemigrate_failed events are
> convenient for determining if compaction is active and to what
> degree migration is succeeding but it's at the wrong level. Other
> users of migration may also want to know if migration is working
> properly and this will be particularly true for any automated
> NUMA migration. This patch moves the counters down to migration
> with the new events called pgmigrate_success and pgmigrate_fail.
> The compact_blocks_moved counter is removed because while it was
> useful for debugging initially, it's worthless now as no meaningful
> conclusions can be drawn from its value.
>
Agreed, "compact_blocks_moved" should have been named
"compact_blocks_scanned" to accurately describe what it was representing.
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-25 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 7:59 [RFC PATCH 0/5] vmstats for compaction, migration and autonuma Mel Gorman
2012-10-22 7:59 ` [PATCH 1/5] mm: compaction: Move migration fail/success stats to migrate.c Mel Gorman
2012-10-25 2:57 ` David Rientjes [this message]
2012-10-22 7:59 ` [PATCH 2/5] mm: migrate: Add a tracepoint for migrate_pages Mel Gorman
2012-10-22 8:05 ` [PATCH 3/5] mm: compaction: Add scanned and isolated counters for compaction Mel Gorman
2012-10-22 8:06 ` [PATCH 4/5] mm: autonuma: Add pte updates, hinting and migration stats for AutoNUMA Mel Gorman
2012-10-22 8:06 ` [PATCH 5/5] mm: autonuma: Specify the migration reason for the tracepoint Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210241953280.2294@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox