From: David Rientjes <rientjes@google.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
liuj97@gmail.com, minchan.kim@gmail.com,
akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
wency@cn.fujitsu.com
Subject: Re: [PATCH 1/2]suppress "Device memoryX does not have a release() function" warning
Date: Thu, 11 Oct 2012 13:23:49 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1210111323370.28062@chino.kir.corp.google.com> (raw)
In-Reply-To: <50765797.3080709@jp.fujitsu.com>
On Thu, 11 Oct 2012, Yasuaki Ishimatsu wrote:
> When calling remove_memory_block(), the function shows following message at
> device_release().
>
> "Device 'memory528' does not have a release() function, it is broken and must
> be fixed."
>
> The reason is memory_block's device struct does not have a release() function.
>
> So the patch registers memory_block_release() to the device's release() function
> for suppressing the warning message. Additionally, the patch moves kfree(mem)
> into the release function since the release function is prepared as a means
> to free a memory_block struct.
>
> CC: David Rientjes <rientjes@google.com>
> CC: Jiang Liu <liuj97@gmail.com>
> Cc: Minchan Kim <minchan.kim@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-11 20:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 5:19 [PATCH v2 0/2] Suppress "Device <device name> " Yasuaki Ishimatsu
2012-10-11 5:22 ` [PATCH 1/2]suppress "Device memoryX " Yasuaki Ishimatsu
2012-10-11 20:23 ` David Rientjes [this message]
2012-10-11 22:30 ` KOSAKI Motohiro
2012-10-11 5:26 ` [PATCH 2/2]suppress "Device nodeX " Yasuaki Ishimatsu
2012-10-11 20:31 ` David Rientjes
2012-10-12 0:13 ` Yasuaki Ishimatsu
2012-10-11 22:33 ` KOSAKI Motohiro
2012-10-17 6:24 ` Wen Congyang
2012-10-17 8:50 ` KOSAKI Motohiro
2012-10-19 5:42 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210111323370.28062@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox