From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] memcg: oom: fix totalpages calculation for swappiness==0
Date: Wed, 10 Oct 2012 13:50:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1210101346010.31237@chino.kir.corp.google.com> (raw)
In-Reply-To: <20121010141142.GG23011@dhcp22.suse.cz>
On Wed, 10 Oct 2012, Michal Hocko wrote:
> Hi,
> I am sending the patch below as an RFC because I am not entirely happy
> about myself and maybe somebody can come up with a different approach
> which would be less hackish.
I don't see this as hackish, if memory.swappiness limits access to swap
then this shouldn't be factored into the calculation, and that's what your
patch fixes.
The reason why the process with the largest rss isn't killed in this case
is because all processes have CAP_SYS_ADMIN so they get a 3% bonus; when
factoring swap into the calculation and subtracting 3% from the score in
oom_badness(), they all end up having an internal score of 1 so they are
all considered equal. It appears like the cgroup_iter_next() iteration
for memcg ooms does this in reverse order, which is actually helpful so it
will select the task that is newer.
The only suggestion I have to make is specify this is for
memory.swappiness in the patch title, otherwise:
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-10 20:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:11 Michal Hocko
2012-10-10 20:50 ` David Rientjes [this message]
2012-10-11 8:50 ` Michal Hocko
2012-10-11 8:57 ` [PATCH] memcg: oom: fix totalpages calculation for memory.swappiness==0 Michal Hocko
2012-10-11 9:13 ` Michal Hocko
2012-10-11 12:20 ` Johannes Weiner
2012-10-12 13:01 ` Michal Hocko
2012-10-11 22:36 ` KOSAKI Motohiro
2012-10-12 13:01 ` Michal Hocko
2012-10-15 22:04 ` [PATCH v2] " Michal Hocko
2012-10-15 22:07 ` [PATCH] doc: describe memcg swappiness more precisely memory.swappiness==0 Michal Hocko
2012-10-16 0:51 ` Kamezawa Hiroyuki
2012-10-16 0:54 ` David Rientjes
2012-11-07 22:10 ` [PATCH v2] memcg: oom: fix totalpages calculation for memory.swappiness==0 Andrew Morton
2012-11-07 22:46 ` Michal Hocko
2012-11-07 22:53 ` Andrew Morton
2012-11-08 8:35 ` Michal Hocko
2012-10-15 9:11 ` [RFC PATCH] memcg: oom: fix totalpages calculation for swappiness==0 Kamezawa Hiroyuki
2012-10-15 9:49 ` Michal Hocko
2012-10-15 14:25 ` KOSAKI Motohiro
2012-10-15 14:47 ` Michal Hocko
2012-10-15 22:33 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210101346010.31237@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox