From: David Rientjes <rientjes@google.com>
To: Fengguang Wu <fengguang.wu@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Glauber Costa <glommer@parallels.com>,
Michal Hocko <mhocko@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@xenotime.net>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"David S. Miller" <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled
Date: Wed, 10 Oct 2012 13:17:30 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1210101312330.28583@chino.kir.corp.google.com> (raw)
In-Reply-To: <20121010143331.GA7880@localhost>
On Wed, 10 Oct 2012, Fengguang Wu wrote:
> > Fengguang, was that this error? Why hasn't it showed up before in the
> > test system?
>
> I do find this error in the build error log:
>
> (.text+0x867f): undefined reference to `sock_update_memcg'
> 2012-09-24 04:54:53 snb next:akpm:69921c3 x86_64-randconfig-s005 0a7f618
>
> Unfortunately it was not reported because the build system could
> miss/ignore build bugs due to various reasons/imperfections. It has
> since then undergo lots of enhancements and as a result, the daily
> reported errors have more than doubled. :-)
>
Not sure where this discussion is going. Do people who can't build their
kernel and have a fix for it need to verify that your build system shows
the same thing first? This isn't a false positive.
As I said in the first message, Randy reported this on September 24 (the
same date you're reporting above) and received no response when he
reported it to LKML here:
http://marc.info/?l=linux-kernel&m=134852557320089
Regardless, Linus' tree is messed up and I don't think we need to go back
reverting patches out of his tree when it's trivial to fix with my patch,
which Michal acked. Sheesh.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-10 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 6:32 David Rientjes
2012-10-10 8:56 ` Glauber Costa
2012-10-10 9:27 ` Michal Hocko
2012-10-10 9:29 ` Glauber Costa
2012-10-10 14:33 ` Fengguang Wu
2012-10-10 20:17 ` David Rientjes [this message]
2012-10-10 20:27 ` Glauber Costa
2012-10-10 9:27 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210101312330.28583@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=glommer@parallels.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox