From: David Rientjes <rientjes@google.com>
To: Christoph Lameter <cl@linux.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Pekka Enberg <penberg@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH] slub: init_kmem_cache_cpus() and put_cpu_partial() can be static
Date: Wed, 3 Oct 2012 11:21:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1210031119290.2412@chino.kir.corp.google.com> (raw)
In-Reply-To: <0000013a26fc13cf-2a85d946-fe2b-4180-a5a0-fbe6781a2934-000000@email.amazonses.com>
On Wed, 3 Oct 2012, Christoph Lameter wrote:
> > > Acked-by: Glauber Costa <glommer@parallels.com>
> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> >
> > Acked-by: David Rientjes <rientjes@google.com>
> >
> > I think init_kmem_cache_cpus() would also benefit from just being inlined
> > into alloc_kmem_cache_cpus().
>
> The compiler will do that if it is advantageous.
>
Which it obviously does with -O2, but I think it would be advantageous to
do this at the source code level as well since we have a function with a
single caller, which happens to be marked inline itself, but we're not
inline. It seems cleaner to me, but it's only a suggestion. Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-10-03 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 8:34 Fengguang Wu
2012-09-28 14:17 ` Christoph Lameter
2012-10-03 4:55 ` David Rientjes
2012-10-03 14:16 ` Christoph Lameter
2012-10-03 18:21 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1210031119290.2412@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@linux.com \
--cc=fengguang.wu@intel.com \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox