From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx145.postini.com [74.125.245.145]) by kanga.kvack.org (Postfix) with SMTP id AD0B96B0044 for ; Wed, 26 Sep 2012 21:40:07 -0400 (EDT) Received: by pbbrq2 with SMTP id rq2so3098748pbb.14 for ; Wed, 26 Sep 2012 18:40:07 -0700 (PDT) Date: Wed, 26 Sep 2012 18:40:04 -0700 (PDT) From: David Rientjes Subject: Re: [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins , Andrew Morton Cc: Linus Torvalds , Andrea Arcangeli , Naoya Horiguchi , KAMEZAWA Hiroyuki , Johannes Weiner , Michel Lespinasse , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org On Wed, 19 Sep 2012, Hugh Dickins wrote: > Good catch, and the patch looks right to me, as far as it goes: > but does it go far enough? > > I hesitate because it looks as if the NR_MLOCK zone page state is > maintained (with incs and decs) in ignorance of THP; so although > you will be correcting the Unevictable kB with your mlock_vma_page(), > the Mlocked kB just above it in /proc/meminfo would still be wrong? > Indeed, NR_MLOCK is a separate problem with regard to thp and it's currently incremented once for every hugepage rather than HPAGE_PMD_NR. mlock_vma_page() needs to increment by hpage_nr_pages(page) like add_page_to_lru_list() does. > I suppose I'm not sure whether this is material for late-3.6: > surely it's not a fix for a recent regression? > Ok, sounds good. If there's no objection, I'd like to ask Andrew to apply this to -mm and remove the cc to stable@vger.kernel.org since the mlock_vma_page() problem above is separate and doesn't conflict with this code, so I'll send a followup patch to address that. Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org