From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id BA8316B0062 for ; Wed, 26 Sep 2012 00:18:05 -0400 (EDT) Received: by padfa10 with SMTP id fa10so143985pad.14 for ; Tue, 25 Sep 2012 21:18:04 -0700 (PDT) Date: Tue, 25 Sep 2012 21:18:02 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] mm/slab: Fix kmem_cache_alloc_node_trace() declaration In-Reply-To: <1348571229-844-2-git-send-email-elezegarcia@gmail.com> Message-ID: References: <1348571229-844-1-git-send-email-elezegarcia@gmail.com> <1348571229-844-2-git-send-email-elezegarcia@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Ezequiel Garcia Cc: kernel-janitors@vger.kernel.org, linux-mm@kvack.org, fengguang.wu@intel.com, Pekka Enberg On Tue, 25 Sep 2012, Ezequiel Garcia wrote: > The bug was introduced in commit 4052147c0afa > "mm, slab: Match SLAB and SLUB kmem_cache_alloc_xxx_trace() prototype". > This isn't a candidate for kernel-janitors@vger.kernel.org, these are patches that are one of Pekka's branches and would never make it to Linus' tree in this form. > Cc: Pekka Enberg > Reported-by: Fengguang Wu > Signed-off-by: Ezequiel Garcia Acked-by: David Rientjes So now we have this for SLAB: extern void *kmem_cache_alloc_node_trace(size_t size, struct kmem_cache *cachep, gfp_t flags, int nodeid); and this for SLUB: extern void *kmem_cache_alloc_node_trace(struct kmem_cache *s, gfp_t gfpflags, int node, size_t size); Would you like to send a follow-up patch to make these the same? (My opinion is that the SLUB variant is the correct order.) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org