From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx204.postini.com [74.125.245.204]) by kanga.kvack.org (Postfix) with SMTP id 57E166B004D for ; Wed, 25 Jul 2012 13:13:28 -0400 (EDT) Date: Wed, 25 Jul 2012 12:13:23 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH 10/10] memcg/sl[au]b: shrink dead caches In-Reply-To: <1343227101-14217-11-git-send-email-glommer@parallels.com> Message-ID: References: <1343227101-14217-1-git-send-email-glommer@parallels.com> <1343227101-14217-11-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , David Rientjes , Pekka Enberg , Greg Thelen , Johannes Weiner , Michal Hocko , Frederic Weisbecker , devel@openvz.org, cgroups@vger.kernel.org, Pekka Enberg , Kamezawa Hiroyuki , Suleiman Souhlal On Wed, 25 Jul 2012, Glauber Costa wrote: > In the slub allocator, when the last object of a page goes away, we > don't necessarily free it - there is not necessarily a test for empty > page in any slab_free path. That is true for the slab allocator as well. In either case calling kmem_cache_shrink() will make the objects go away by draining the cached objects and freeing the pages used for the objects back to the page allocator. You do not need this patch. Just call the proper functions to drop the objecgts in the caches in either allocator. > The slab allocator has a time based reaper that would eventually get rid > of the objects, but we can also call it explicitly, since dead caches > are not a likely event. So this is already for both allocators? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org