linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Rik van Riel <riel@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] mm: Warn about costly page allocation
Date: Wed, 11 Jul 2012 13:40:56 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1207111337430.3635@chino.kir.corp.google.com> (raw)
In-Reply-To: <4FFD15B2.6020001@kernel.org>

On Wed, 11 Jul 2012, Minchan Kim wrote:

> I agree it's an ideal but the problem is that it's too late.
> Once product is released, we have to recall all products in the worst case.
> The fact is that lumpy have helped high order allocation implicitly but we removed it
> without any notification or information. It's a sort of regression and we can't say
> them "Please report us if it happens". It's irresponsible, too.
> IMHO, at least, what we can do is to warn about it before it's too late.
> 

High order allocations that fail should still display a warning message 
when __GFP_NOWARN is not set, so I don't see what this additional warning 
adds.  I don't think it's responsible to ask admins to know what lumpy 
reclaim is, what memory compaction is, or when a system tends to have more 
high order allocations when memory compaction would be helpful.

What we can do, though, is address bug reports as they are reported when 
high order allocations fail and previous kernels are successful.  I 
haven't seen any lately.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-07-11 20:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 23:55 Minchan Kim
2012-07-10  0:03 ` Minchan Kim
2012-07-10  0:08 ` Andrew Morton
2012-07-10  0:25   ` Minchan Kim
2012-07-11  1:02     ` David Rientjes
2012-07-11  2:23       ` Minchan Kim
2012-07-11  2:50         ` Cong Wang
2012-07-11  5:33         ` David Rientjes
2012-07-11  5:57           ` Minchan Kim
2012-07-11 20:40             ` David Rientjes [this message]
2012-07-11 21:18               ` Minchan Kim
2012-07-11 23:02                 ` David Rientjes
2012-07-11 23:55                   ` Minchan Kim
2012-07-12  2:33                     ` David Rientjes
2012-07-12  3:00                       ` Minchan Kim
2012-07-10  1:02 Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1207111337430.3635@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox