From: David Rientjes <rientjes@google.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] mm: Warn about costly page allocation
Date: Tue, 10 Jul 2012 18:02:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1207101756070.684@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120710002510.GB5935@bbox>
On Tue, 10 Jul 2012, Minchan Kim wrote:
> > So I dunno, this all looks like we have a kernel problem and we're
> > throwing our problem onto hopelessly ill-equipped users of that kernel?
>
> As you know, this patch isn't for solving regular high-order allocations.
> As I wrote down, The problem is that we removed lumpy reclaim without any
> notification for user who might have used it implicitly.
And so now they're running with CONFIG_DEBUG_VM to try to figure out why
they have seen a regression, which is required for your patch to have an
effect?
> If such user disable compaction which is a replacement of lumpy reclaim,
> their system might be broken in real practice while test is passing.
> So, the goal is that let them know it in advance so that I expect they can
> test it stronger than old.
>
So what are they supposed to do? Enable CONFIG_COMPACTION as soon as they
see the warning? When they have seen the warning a specific number of
times? How much is "very few" high-order allocations over what time
period? This is what anybody seeing these messages for the first time is
going to ask.
> Although they see the page allocation failure with compaction, it would
> be very helpful reports. It means we need to make compaction more
> aggressive about reclaiming pages.
>
If CONFIG_COMPACTION is disabled, then how will making compaction more
aggressive about reclaiming pages help?
Should we consider enabling CONFIG_COMPACTION in defconfig? If not, would
it be possible with a different extfrag_threshold (and more aggressive
when things like THP are enabled)?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-11 1:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 23:55 Minchan Kim
2012-07-10 0:03 ` Minchan Kim
2012-07-10 0:08 ` Andrew Morton
2012-07-10 0:25 ` Minchan Kim
2012-07-11 1:02 ` David Rientjes [this message]
2012-07-11 2:23 ` Minchan Kim
2012-07-11 2:50 ` Cong Wang
2012-07-11 5:33 ` David Rientjes
2012-07-11 5:57 ` Minchan Kim
2012-07-11 20:40 ` David Rientjes
2012-07-11 21:18 ` Minchan Kim
2012-07-11 23:02 ` David Rientjes
2012-07-11 23:55 ` Minchan Kim
2012-07-12 2:33 ` David Rientjes
2012-07-12 3:00 ` Minchan Kim
2012-07-10 1:02 Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1207101756070.684@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox