From: Christoph Lameter <cl@linux.com>
To: JoonSoo Kim <js1304@gmail.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Pekka Enberg <penberg@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow)
Date: Mon, 9 Jul 2012 08:55:02 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1207090853450.27519@router.home> (raw)
In-Reply-To: <CAAmzW4OD2_ODyeY7c1VMPajwzovOms5M8Vnw=XP=uGUyPogiJQ@mail.gmail.com>
On Mon, 9 Jul 2012, JoonSoo Kim wrote:
> 2012/7/8 Fengguang Wu <fengguang.wu@intel.com>:
> > Hi Vegard,
> >
> > This warning code is triggered for the attached config:
> >
> > __lockdep_trace_alloc():
> > /*
> > * Oi! Can't be having __GFP_FS allocations with IRQs disabled.
> > */
> > if (DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)))
> > return;
> >
> > Where the irq is possibly disabled at the beginning of __slab_alloc():
> >
> > local_irq_save(flags);
>
> Currently, in slub code, kmemcheck_alloc_shadow is always invoked with
> irq_disabled.
> I think that something like below is needed.
Or you could move the kmem_check_enabled section to occur before the irq
is disabled.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-09 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 4:00 Fengguang Wu
2012-07-08 16:12 ` JoonSoo Kim
2012-07-08 23:01 ` David Rientjes
2012-07-09 1:52 ` Fengguang Wu
2012-07-09 9:09 ` Pekka Enberg
2012-07-09 10:36 ` [patch] mm, slub: ensure irqs are enabled for kmemcheck David Rientjes
2012-07-09 13:46 ` Steven Rostedt
2012-07-09 14:06 ` Fengguang Wu
2012-07-09 21:00 ` [patch v2] " David Rientjes
2012-07-10 19:44 ` Pekka Enberg
2012-07-09 13:52 ` WARNING: __GFP_FS allocations with IRQs disabled (kmemcheck_alloc_shadow) JoonSoo Kim
2012-07-09 13:55 ` Christoph Lameter [this message]
2012-07-09 13:52 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1207090853450.27519@router.home \
--to=cl@linux.com \
--cc=fengguang.wu@intel.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox