From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx126.postini.com [74.125.245.126]) by kanga.kvack.org (Postfix) with SMTP id 9C0D96B0096 for ; Mon, 9 Jul 2012 06:43:51 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so23090501pbb.14 for ; Mon, 09 Jul 2012 03:43:50 -0700 (PDT) Date: Mon, 9 Jul 2012 03:43:48 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] mm/hugetlb: split out is_hugetlb_entry_migration_or_hwpoison In-Reply-To: <1341828761-11195-1-git-send-email-liwp.linux@gmail.com> Message-ID: References: <1341828761-11195-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: linux-mm@kvack.org, Michal Hocko , KAMEZAWA Hiroyuki , Mel Gorman , Andrew Morton , linux-kernel@vger.kernel.org On Mon, 9 Jul 2012, Wanpeng Li wrote: > From: Wanpeng Li > > Code was duplicated in two functions, clean it up. > > Signed-off-by: Wanpeng Li > --- > mm/hugetlb.c | 20 +++++++++----------- > 1 files changed, 9 insertions(+), 11 deletions(-) Nack, this makes the code more convoluted then the hugetlb code already is and savings two lines of code isn't worth it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org