From: David Rientjes <rientjes@google.com>
To: Cong Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
WANG Cong <xiyou.wangcong@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org
Subject: Re: [Patch] mm/policy: use int instead of unsigned for nid
Date: Tue, 3 Jul 2012 23:43:40 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1207032342120.32556@chino.kir.corp.google.com> (raw)
In-Reply-To: <1341370901-14187-1-git-send-email-amwang@redhat.com>
On Wed, 4 Jul 2012, Cong Wang wrote:
> From: WANG Cong <xiyou.wangcong@gmail.com>
>
> 'nid' should be 'int', not 'unsigned'.
>
unsigned is already of type int, so you're saying these occurrences should
become signed, but that's not true since they never return NUMA_NO_NODE.
They are all safe returning unsigned.
And alloc_page_interleave() doesn't exist anymore since the sched/numa
bits were merged into sched/core, so nobody could apply this patch anyway.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-04 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 3:01 Cong Wang
2012-07-04 6:43 ` David Rientjes [this message]
2012-07-05 13:37 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1207032342120.32556@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox