From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx130.postini.com [74.125.245.130]) by kanga.kvack.org (Postfix) with SMTP id 71B0D6B005A for ; Fri, 29 Jun 2012 18:30:31 -0400 (EDT) Received: by dakp5 with SMTP id p5so6064815dak.14 for ; Fri, 29 Jun 2012 15:30:30 -0700 (PDT) Date: Fri, 29 Jun 2012 15:30:28 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH v2] KSM: numa awareness sysfs knob In-Reply-To: <20120629164706.GA7831@cmpxchg.org> Message-ID: References: <1340970592-25001-1-git-send-email-pholasek@redhat.com> <20120629160510.GA10082@cmpxchg.org> <20120629163033.GA11327@stainedmachine.redhat.com> <20120629164706.GA7831@cmpxchg.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Petr Holasek , Hugh Dickins , Andrew Morton , Andrea Arcangeli , Chris Wright , Izik Eidus , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anton Arapov On Fri, 29 Jun 2012, Johannes Weiner wrote: > > I started with exactly same idea as you described above in the first > > RFC, link: https://lkml.org/lkml/2011/11/30/91 > > But this approach turned out to be more complicated than it looked > > (see two last emails in thread) and complexity of solution would rise > > a lot. > > Oh, I should have checked the archives given that it's v2. I expected > it to get complex but didn't put enough thought into it to see /that/ > amount of complexity. Sorry. > > Carry on, then :-) > I don't think it's an unfair amount of complexity to ask for, and I don't see the problem with ksm merging two pages that have a distance under the configured threshold and leaving the third page unmerged; by configuring the threshold (which should be a char, not an int) the admin has specified the locality that is necessary for optimal performance so has knowingly restricted ksm in that way. I'd rename it to ksm_merge_distance, which is more similar to reclaim_distance, and return to the first version of this patch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org