From: David Rientjes <rientjes@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Petr Holasek <pholasek@redhat.com>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Chris Wright <chrisw@sous-sol.org>,
Izik Eidus <izik.eidus@ravellosystems.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH v2] KSM: numa awareness sysfs knob
Date: Fri, 29 Jun 2012 15:30:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206291526180.15200@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120629164706.GA7831@cmpxchg.org>
On Fri, 29 Jun 2012, Johannes Weiner wrote:
> > I started with exactly same idea as you described above in the first
> > RFC, link: https://lkml.org/lkml/2011/11/30/91
> > But this approach turned out to be more complicated than it looked
> > (see two last emails in thread) and complexity of solution would rise
> > a lot.
>
> Oh, I should have checked the archives given that it's v2. I expected
> it to get complex but didn't put enough thought into it to see /that/
> amount of complexity. Sorry.
>
> Carry on, then :-)
>
I don't think it's an unfair amount of complexity to ask for, and I don't
see the problem with ksm merging two pages that have a distance under the
configured threshold and leaving the third page unmerged; by configuring
the threshold (which should be a char, not an int) the admin has specified
the locality that is necessary for optimal performance so has knowingly
restricted ksm in that way.
I'd rename it to ksm_merge_distance, which is more similar to
reclaim_distance, and return to the first version of this patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-29 22:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 11:49 Petr Holasek
2012-06-29 13:03 ` Cong Wang
2012-06-29 13:23 ` Petr Holasek
2012-06-29 16:05 ` Johannes Weiner
2012-06-29 16:30 ` Petr Holasek
2012-06-29 16:47 ` Johannes Weiner
2012-06-29 22:30 ` David Rientjes [this message]
2012-06-30 11:40 ` Petr Holasek
2012-07-02 21:26 ` David Rientjes
2012-07-03 17:02 ` Petr Holasek
2012-06-29 21:17 ` Andrew Morton
2012-06-29 22:50 ` David Rientjes
2012-06-30 9:43 ` Izik Eidus
2012-06-30 12:29 ` Petr Holasek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206291526180.15200@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anton@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=izik.eidus@ravellosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pholasek@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox