From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx141.postini.com [74.125.245.141]) by kanga.kvack.org (Postfix) with SMTP id C2D386B005A for ; Fri, 29 Jun 2012 17:41:13 -0400 (EDT) Received: by dakp5 with SMTP id p5so6017609dak.14 for ; Fri, 29 Jun 2012 14:41:13 -0700 (PDT) Date: Fri, 29 Jun 2012 14:41:10 -0700 (PDT) From: David Rientjes Subject: Re: [RFC][PATCH 2/2] memcg : remove -ENOMEM at page migration. In-Reply-To: <4FEC308F.4020909@jp.fujitsu.com> Message-ID: References: <4FEC300A.7040209@jp.fujitsu.com> <4FEC308F.4020909@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Kamezawa Hiroyuki Cc: linux-mm , Michal Hocko , Johannes Weiner , Andrew Morton , Tejun Heo On Thu, 28 Jun 2012, Kamezawa Hiroyuki wrote: > For handling many kinds of races, memcg adds an extra charge to > page's memcg at page migration. But this affects the page compaction > and make it fail if the memcg is under OOM. > > This patch uses res_counter_charge_nofail() in page migration path > and remove -ENOMEM. By this, page migration will not fail by the > status of memcg. > > Reported-by: David Rientjes > Signed-off-by: KAMEZAWA Hiroyuki Acked-by: David Rientjes This is a very good improvement for page migration under memory compaction and increases the liklihood that it will do useful work for transparent hugepage allocations, thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org