From: David Rientjes <rientjes@google.com>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC][PATCH 2/2] memcg : remove -ENOMEM at page migration.
Date: Fri, 29 Jun 2012 14:41:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206291439080.11416@chino.kir.corp.google.com> (raw)
In-Reply-To: <4FEC308F.4020909@jp.fujitsu.com>
On Thu, 28 Jun 2012, Kamezawa Hiroyuki wrote:
> For handling many kinds of races, memcg adds an extra charge to
> page's memcg at page migration. But this affects the page compaction
> and make it fail if the memcg is under OOM.
>
> This patch uses res_counter_charge_nofail() in page migration path
> and remove -ENOMEM. By this, page migration will not fail by the
> status of memcg.
>
> Reported-by: David Rientjes <rientjes@google.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
This is a very good improvement for page migration under memory compaction
and increases the liklihood that it will do useful work for transparent
hugepage allocations, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-29 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 10:20 [RFC][PATCH 1/2] add res_counter_usage_safe Kamezawa Hiroyuki
2012-06-28 10:23 ` [RFC][PATCH 2/2] memcg : remove -ENOMEM at page migration Kamezawa Hiroyuki
2012-06-29 21:41 ` David Rientjes [this message]
2012-07-02 16:48 ` Michal Hocko
2012-06-28 10:57 ` [RFC][PATCH 1/2] add res_counter_usage_safe Glauber Costa
2012-06-29 2:35 ` Kamezawa Hiroyuki
2012-06-29 21:34 ` David Rientjes
2012-07-02 16:52 ` Michal Hocko
2012-07-04 13:19 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206291439080.11416@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox