From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx148.postini.com [74.125.245.148]) by kanga.kvack.org (Postfix) with SMTP id A99D36B0081 for ; Tue, 26 Jun 2012 01:24:47 -0400 (EDT) Received: by dakp5 with SMTP id p5so7712617dak.14 for ; Mon, 25 Jun 2012 22:24:47 -0700 (PDT) Date: Mon, 25 Jun 2012 22:24:44 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 09/11] memcg: propagate kmem limiting information to children In-Reply-To: <20120625162352.51997c5a.akpm@linux-foundation.org> Message-ID: References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-10-git-send-email-glommer@parallels.com> <20120625162352.51997c5a.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Glauber Costa , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal On Mon, 25 Jun 2012, Andrew Morton wrote: > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -287,7 +287,11 @@ struct mem_cgroup { > > * Should the accounting and control be hierarchical, per subtree? > > */ > > bool use_hierarchy; > > - bool kmem_accounted; > > + /* > > + * bit0: accounted by this cgroup > > + * bit1: accounted by a parent. > > + */ > > + volatile unsigned long kmem_accounted; > > I suggest > > unsigned long kmem_accounted; /* See KMEM_ACCOUNTED_*, below */ > > > bool oom_lock; > > atomic_t under_oom; > > @@ -340,6 +344,9 @@ struct mem_cgroup { > > #endif > > }; > > > > +#define KMEM_ACCOUNTED_THIS 0 > > +#define KMEM_ACCOUNTED_PARENT 1 > > And then document the fields here. > In hex, please? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org