From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx121.postini.com [74.125.245.121]) by kanga.kvack.org (Postfix) with SMTP id D02C76B011E for ; Tue, 26 Jun 2012 00:57:56 -0400 (EDT) Received: by dakp5 with SMTP id p5so7682969dak.14 for ; Mon, 25 Jun 2012 21:57:56 -0700 (PDT) Date: Mon, 25 Jun 2012 21:57:54 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs In-Reply-To: <1340633728-12785-12-git-send-email-glommer@parallels.com> Message-ID: References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-12-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg , Suleiman Souhlal , Frederic Weisbecker On Mon, 25 Jun 2012, Glauber Costa wrote: > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > index ccc1899..914ec07 100644 > --- a/include/linux/thread_info.h > +++ b/include/linux/thread_info.h > @@ -61,6 +61,12 @@ extern long do_no_restart_syscall(struct restart_block *parm); > # define THREADINFO_GFP (GFP_KERNEL | __GFP_NOTRACK) > #endif > > +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM > +# define THREADINFO_GFP_ACCOUNTED (THREADINFO_GFP | __GFP_KMEMCG) > +#else > +# define THREADINFO_GFP_ACCOUNTED (THREADINFO_GFP) > +#endif > + This type of requirement is going to become nasty very quickly if nobody can use __GFP_KMEMCG without testing for CONFIG_CGROUP_MEM_RES_CTLR_KMEM. Perhaps define __GFP_KMEMCG to be 0x0 if it's not enabled, similar to how kmemcheck does? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org