Re: [patch] mm, oom: replace some information in tasklist dump

[David Rientjes <rientjes@google.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1147 bytes --]

On Fri, 22 Jun 2012, KOSAKI Motohiro wrote:

> >> > -               pr_info("[%5d] %5d %5d %8lu %8lu %3u     %3d         %5d %s\n",
> >> > +               pr_info("[%5d] %5d %5d %8lu %8lu %7lu %8lu         %5d %s\n",
> >> >                        task->pid, from_kuid(&init_user_ns, task_uid(task)),
> >> >                        task->tgid, task->mm->total_vm, get_mm_rss(task->mm),
> >> > -                       task_cpu(task), task->signal->oom_adj,
> >> > +                       task->mm->nr_ptes,
> >>
> >> nr_ptes should be folded into rss. it's "resident".
> >> btw, /proc rss info should be fixed too.
> >
> > If we can fold rss into get_mm_rss() and every caller is ok with that,
> > then we can remove showing it here and adding it explicitly in
> > oom_badness().
> 
> No worth to make fragile ABI. Do you have any benefit?
> 

Yes, because this is exactly where we would discover something like a 
mm->nr_ptes accounting issue since it would result in an oom kill and we'd 
notice the mismatch between nr_ptes and rss in the tasklist dump.

I also don't think anybody is parsing this tasklist dump or I wouldn't be 
changing it here.