From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [patch] mm, oom: replace some information in tasklist dump
Date: Fri, 22 Jun 2012 16:10:56 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206221609220.15114@chino.kir.corp.google.com> (raw)
In-Reply-To: <CAHGf_=p4SS7qA_eRpBF0PawyUa8DpYncL0LS-=B4tHFaDUKV-w@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 909 bytes --]
On Fri, 22 Jun 2012, KOSAKI Motohiro wrote:
> > @@ -396,10 +396,11 @@ static void dump_tasks(const struct mem_cgroup *memcg, const nodemask_t *nodemas
> > continue;
> > }
> >
> > - pr_info("[%5d] %5d %5d %8lu %8lu %3u %3d %5d %s\n",
> > + pr_info("[%5d] %5d %5d %8lu %8lu %7lu %8lu %5d %s\n",
> > task->pid, from_kuid(&init_user_ns, task_uid(task)),
> > task->tgid, task->mm->total_vm, get_mm_rss(task->mm),
> > - task_cpu(task), task->signal->oom_adj,
> > + task->mm->nr_ptes,
>
> nr_ptes should be folded into rss. it's "resident".
> btw, /proc rss info should be fixed too.
>
If we can fold rss into get_mm_rss() and every caller is ok with that,
then we can remove showing it here and adding it explicitly in
oom_badness().
next prev parent reply other threads:[~2012-06-22 23:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 21:45 David Rientjes
2012-06-22 22:54 ` KOSAKI Motohiro
2012-06-22 23:10 ` David Rientjes [this message]
2012-06-22 23:12 ` KOSAKI Motohiro
2012-06-22 23:36 ` David Rientjes
2012-06-23 0:19 ` KOSAKI Motohiro
2012-06-24 20:43 ` David Rientjes
2012-06-25 7:37 ` KOSAKI Motohiro
2012-06-25 9:16 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206221609220.15114@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox